Attention is currently required from: Lance Zhao, Paul Menzel, Tim Wawrzynczak.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56763 )
Change subject: arch/x86/acpi: rename KEY_KBDILLUMTOGGLE to KEY_KBD_BKLIGHT_TOGGLE
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56763/comment/a904503a_f5ac43c1
PS2, Line 9: Also change scan code from e02b to e01e
Why? Are you sure, that is compatible wtih all devices?
This is trying to fill the gaps in the standard table. The advise from Googler is using e01e for the keyboard backlight toggle key. (https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3060242)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I402192ff354f30da35aec43202df9f1407911d34
Gerrit-Change-Number: 56763
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 03 Aug 2021 13:44:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment