Attention is currently required from: Furquan Shaikh, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 )
Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
whoops, not select max98357 as well. BTW, there is no sar sensor sx9324 in kernel 5. […]
+1, will add. Filed a bug with Alex to see about the driver
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51145/comment/8c969b89_565050bf
PS1, Line 186: device generic 0 on end
weird, why builedbot no compliant before :p
Need to select the MAX98357A driver 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc
Gerrit-Change-Number: 51145
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Mar 2021 16:20:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment