[XS] Change in coreboot[main]: acpi/acpi: update ACPI_DBG2_PORT_SERIAL_16550 subtype

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79219?usp=email )

Change subject: acpi/acpi: update ACPI_DBG2_PORT_SERIAL_16550 subtype
......................................................................

acpi/acpi: update ACPI_DBG2_PORT_SERIAL_16550 subtype

The Microsoft Debug Port Table 2 (DBG2) specification says that the
serial port subtype 0x00 should only be used for I/O-mapped 16550
compatible UARTs. The subtype 0x12 is a superset of that, and supports
specifying MMIO vs IO and the register access size via the generic
address structure. Rename the subtype 0x00 definition to
ACPI_DBG2_PORT_SERIAL_16550_IO_ONLY and add the subtype 0x12 definition
as new ACPI_DBG2_PORT_SERIAL_16550, so that the acpi_write_dbg2_uart
function will write the correct subtype for the generic 16550 UART.

Signed-off-by: Felix Held 
Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79219
Reviewed-by: Matt DeVillier 
Tested-by: build bot (Jenkins) 
---
M src/include/acpi/acpi.h
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h
index 9a9a66d..a26d735 100644
--- a/src/include/acpi/acpi.h
+++ b/src/include/acpi/acpi.h
@@ -866,12 +866,13 @@
 _Static_assert(sizeof(acpi_madt_gic_its_t) == 20, "Wrong MADT acpi_madt_gic_its_t size\n");

#define ACPI_DBG2_PORT_SERIAL			0x8000
-#define  ACPI_DBG2_PORT_SERIAL_16550		0x0000
+#define  ACPI_DBG2_PORT_SERIAL_16550_IO_ONLY	0x0000
 #define  ACPI_DBG2_PORT_SERIAL_16550_DBGP	0x0001
 #define  ACPI_DBG2_PORT_SERIAL_ARM_PL011	0x0003
 #define  ACPI_DBG2_PORT_SERIAL_ARM_SBSA		0x000e
 #define  ACPI_DBG2_PORT_SERIAL_ARM_DDC		0x000f
 #define  ACPI_DBG2_PORT_SERIAL_BCM2835		0x0010
+#define  ACPI_DBG2_PORT_SERIAL_16550		0x0012
 #define ACPI_DBG2_PORT_IEEE1394			0x8001
 #define  ACPI_DBG2_PORT_IEEE1394_STANDARD	0x0000
 #define ACPI_DBG2_PORT_USB			0x8002