Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
Roger Wang has posted comments on this change by Roger Wang. ( https://review.coreboot.org/c/coreboot/+/85133?usp=email )
Change subject: mb/google/nissa/var/pujjoga: Turn off camera during S0ix
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/pujjoga/variant.c:
https://review.coreboot.org/c/coreboot/+/85133/comment/dbd028bc_766fa119?usp... :
PS8, Line 9: #include <delay.h>
no need.
Done. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85133?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c7f5d314e8b2a4d5f72c452128f6c4b57c45993
Gerrit-Change-Number: 85133
Gerrit-PatchSet: 9
Gerrit-Owner: Roger Wang
roger2.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikki Huang
nikki.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 21 Nov 2024 02:23:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com