Change in ...coreboot[master]: src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in gerrit-avatars[master]:...

Mike Banon (Code Review)

30 Jun 2019 30 Jun '19

4 p.m.

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33917

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

These tables may be used to adjust memory timing settings.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33917/1

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c index dfd27cd..643b306 100644 --- a/src/mainboard/asus/am1i-a/buildOpts.c +++ b/src/mainboard/asus/am1i-a/buildOpts.c @@ -42,6 +42,9 @@ #include <vendorcode/amd/agesa/f16kb/Proc/Common/CreateStruct.h> #include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h> #include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h> +/* These tables are optional and may be used to adjust memory timing settings */ +#include <vendorcode/amd/agesa/f16kb/Proc/Mem/mm.h> +#include <vendorcode/amd/agesa/f16kb/Proc/Mem/mn.h>

/* Select the CPU family. */ #define INSTALL_FAMILY_16_MODEL_0x_SUPPORT TRUE

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Mike Banon (Code Review)

30 Jun 30 Jun

5:32 p.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Patch Set 1:

am1i-a/buildOpts.c patch series [5/8] : 1st = CB:33913 , 2nd = CB:33914 , 3rd = CB:33915 , 4th = CB:33916 ; 5th = CB:33917 <-- you are here ; 6th = CB:33918 , 7th = CB:33919 , 8th = CB:33920

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 30 Jun 2019 15:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

3 Jul 3 Jul

9:11 a.m.

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Patch Set 1:

I'm not using them yet, but they might become useful soon...

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 03 Jul 2019 07:11:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

9 Apr 9 Apr

3:34 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33917

to look at the new patch set (#6).

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

These tables may be used to adjust memory timing settings.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33917/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

5:51 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Patch Set 6:

Same SHA256 when built with "make BUILD_TIMELESS=1" - probably because I didn't use anything from these includes yet.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Apr 2020 15:51:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10 Apr 10 Apr

1:35 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Patch Set 6:

...

Patch Set 6:

Same SHA256 when built with "make BUILD_TIMELESS=1" - probably because I didn't use anything from these includes yet.

Maybe include them in the patch that uses them?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Apr 2020 23:35:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

11 Apr 11 Apr

9:28 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33917

to look at the new patch set (#8).

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

These tables may be used to adjust memory timing settings. Tested with BUILD_TIMELESS=1, hashes do not change.

Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d --- M src/mainboard/asus/am1i-a/buildOpts.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33917/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Mike Banon (Code Review)

9:35 a.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Patch Set 8:

...

Patch Set 6:

...
Patch Set 6:

Same SHA256 when built with "make BUILD_TIMELESS=1" - probably because I didn't use anything from these includes yet.

Maybe include them in the patch that uses them?

Would be nice to have these includes already in place, also considering that the other boards like G505S have them.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Apr 2020 07:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:02 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Patch Set 8:

why? are those included used?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Apr 2020 10:02:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mike Banon (Code Review)

17 Apr 17 Apr

4:32 p.m.

New subject: Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33917 )

Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings ......................................................................

Abandoned

Working setup for the memory timings: see CB:40489 and other AMD_XMP.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d Gerrit-Change-Number: 33917 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1681

days inactive

1973

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Mike Banon (Code Review)