Attention is currently required from: Jason Glenesk, ritul guru, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70207 )
Change subject: mb/amd/mayan/gpio: Configure mayan GPIOs ......................................................................
Patch Set 1:
(5 comments)
File src/mainboard/amd/mayan/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/70207/comment/50bc0660_df0506d0 PS1, Line 39: do the gpios 78 and 79 (nvme ssd aux reset) also need to be configured in bootblock?
File src/mainboard/amd/mayan/gpio.c:
https://review.coreboot.org/c/coreboot/+/70207/comment/f9397e8e_db60040c PS1, Line 30: /* USB_HDR_P0/1/2/3_SMI_L */ the name says smi, but sci is probably the way to go, since we try to not do things in smm that don't need to be done in smm
https://review.coreboot.org/c/coreboot/+/70207/comment/38d36ed1_e33ab102 PS1, Line 112: /* Unused */ is it unused or not available on the package?
https://review.coreboot.org/c/coreboot/+/70207/comment/035390ad_bf0d6333 PS1, Line 158: PAD_SCI(GPIO_139, PULL_UP, EDGE_LOW), this isn't a gevent capable gpio
https://review.coreboot.org/c/coreboot/+/70207/comment/54ca79b6_9f5ea413 PS1, Line 187: PAD_SCI(GPIO_157, PULL_UP, EDGE_LOW), this isn't a gevent capable gpio
-
Felix Held (Code Review)