[M] Change in coreboot[main]: soc/intel/xeon_sp: Remove PAM unlock operations

[Arthur Heymans (Code Review)]

Attention is currently required from: Shuo Liu.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81349?usp=email )

Change subject: soc/intel/xeon_sp: Remove PAM unlock operations
......................................................................


Patch Set 15:

(1 comment)

File src/soc/intel/xeon_sp/cpx/chip.c:

https://review.coreboot.org/c/coreboot/+/81349/comment/ca561531_393b1387 :
PS15, Line 164: /* Only call this code from socket0! */
              : static void unlock_pam_regions(void)
              : {
              : 	uint32_t pam0123_unlock_dram = 0x33333330;
              : 	uint32_t pam456_unlock_dram = 0x00333333;
              : 	/* Get UBOX(1) for socket0 */
              : 	uint32_t bus1 = socket0_get_ubox_busno(PCU_IIO_STACK);
              : 
              : 	/* Assume socket0 owns PCI segment 0 */
              : 	pci_io_write_config32(PCI_DEV(bus1, SAD_ALL_DEV, SAD_ALL_FUNC),
              : 		SAD_ALL_PAM0123_CSR, pam0123_unlock_dram);
              : 	pci_io_write_config32(PCI_DEV(bus1, SAD_ALL_DEV, SAD_ALL_FUNC),
              : 		SAD_ALL_PAM456_CSR, pam456_unlock_dram);
              : 
              : 	uint32_t reg1 = pci_io_read_config32(PCI_DEV(bus1, SAD_ALL_DEV,
              : 		SAD_ALL_FUNC), SAD_ALL_PAM0123_CSR);
              : 	uint32_t reg2 = pci_io_read_config32(PCI_DEV(bus1, SAD_ALL_DEV,
              : 		SAD_ALL_FUNC), SAD_ALL_PAM456_CSR);
              : 	printk(BIOS_DEBUG, "%s:%s pam0123_csr: 0x%x, pam456_csr: 0x%x\n",
              : 		__FILE__, __func__, reg1, reg2);
              : }
Why is this code duplicated in cpx and skx. It was also valid for SPR-SP but not used. Why not have the function definiton in common code but call it in SOC specific code?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81349?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3fd1d806807449e6a4d9d4d2c8a47ce61ed53018
Gerrit-Change-Number: 81349
Gerrit-PatchSet: 15
Gerrit-Owner: Shuo Liu <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Christian Walter <[e-mail]>
Gerrit-Reviewer: Johnny Lin <[e-mail]>
Gerrit-Reviewer: Jonathan Zhang <[e-mail]>
Gerrit-Reviewer: Lean Sheng Tan <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Tim Chu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Shuo Liu <[e-mail]>
Gerrit-Comment-Date: Mon, 01 Apr 2024 08:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment