Attention is currently required from: Jason Glenesk, Felix Held.
Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70282 )
Change subject: mb/amd/birman/gpio: Change non-GEvent GPIOs to PAD_INT ......................................................................
mb/amd/birman/gpio: Change non-GEvent GPIOs to PAD_INT
Two GPIOs were set as SCI, but are not GEvent capable pins on morgana.
Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Change-Id: I00dc1b2595c047ce6898b394061d119ac8680755 --- M src/mainboard/amd/birman/early_gpio.c M src/mainboard/amd/birman/gpio.c 2 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/70282/1
diff --git a/src/mainboard/amd/birman/early_gpio.c b/src/mainboard/amd/birman/early_gpio.c index 89f7ef9..a337e1e 100644 --- a/src/mainboard/amd/birman/early_gpio.c +++ b/src/mainboard/amd/birman/early_gpio.c @@ -23,7 +23,7 @@ /* ESPI_ALERT_L */ PAD_NF(GPIO_22, ESPI_ALERT_D1, PULL_NONE), /* TPM IRQ */ - PAD_SCI(GPIO_130, PULL_UP, EDGE_LOW), + PAD_INT(GPIO_130, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* SPI_ROM_REQ */ PAD_NF(GPIO_67, SPI_ROM_REQ, PULL_NONE), /* SPI_ROM_GNT */ diff --git a/src/mainboard/amd/birman/gpio.c b/src/mainboard/amd/birman/gpio.c index 50cf9db..d70fefd 100644 --- a/src/mainboard/amd/birman/gpio.c +++ b/src/mainboard/amd/birman/gpio.c @@ -65,7 +65,7 @@ /* ESPI_CS_L */ PAD_NF(GPIO_30, ESPI_CS_L, PULL_NONE), /* INT_CLKREQ_L */ - PAD_SCI(GPIO_31, PULL_UP, EDGE_LOW), + PAD_INT(GPIO_31, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* LPC_RST_L */ PAD_NF(GPIO_32, LPC_RST_L, PULL_NONE), /* GPIO_33 - GPIO_37: Not available */ @@ -138,7 +138,7 @@ PAD_NF(GPIO_116, CLK_REQ2_L, PULL_NONE), /* GPIO_117 - GPIO_129: Not available */ /* TPM IRQ */ - PAD_SCI(GPIO_130, PULL_UP, EDGE_LOW), + PAD_INT(GPIO_130, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), /* CLK_REQ3_L */ PAD_NF(GPIO_131, CLK_REQ3_L, PULL_NONE), /* CLK_REQ4_L */