Change in coreboot[master]: console: serial: add optional delay to wait for BMC serial routing - coreboot-gerrit

3 Nov 2019


      Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36591 )
Change subject: console: serial: add optional delay to wait for BMC serial routing
......................................................................
Patch Set 4:
...
Patch Set 4:
...
Patch Set 4:
I'm not really convinced that adding quirk handling in generic common code like this is such a good idea. What is wrong with the current code which adds a delay in the bootblock in the mainboard code?
Because not only one board has that problem
... and we should provide a way to disable the delay when the user flashes a fixed BMC version for example
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/36591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d6599b76384fc94a00a9cfc1794ebfe34863ff9
Gerrit-Change-Number: 36591
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 03 Nov 2019 14:59:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment