Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Subrata Banik, Aaron Durbin, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57930 )
Change subject: soc/intel/*: only enable PM Timer emulation if the PM Timer is disabled
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I wonder why the SKL/KBL BIOS spec says that ACPI timer emulation should always be enabled. […]
Reading SKL/KBL BWG once again, I realized that it mentions idle states. I have some idea..... could it be that microcode does not *always* redirect read/writes to/from the timer but *only* when it's disabled??
"Some legacy OSes cannot tolerate ACPI timer stop running during idle states,
therefore, result in more power consumption. Intel microarchitecture code name
Skylake and Kaby Lake support ACPI Timer Emulation via MSR 0x121.
The emulated ACPI timer allows disabling of the ACPI Timer (PM1_TMR) to have no
impact on the system, with the exception that TMR_STS will not be set on an overflow condition. All aligned 32-bit reads to the ACPI Timer port are valid and will behave as if the ACPI timer remains enabled."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60a775bd6eb4206750f606ce8a8777d2e2dfb579
Gerrit-Change-Number: 57930
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 26 Sep 2021 11:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment