HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36454 )
Change subject: soc/mediatek: Add missing '#include <console/console.h>' ......................................................................
soc/mediatek: Add missing '#include <console/console.h>'
Change-Id: I2e79ff3352fe974a070b7b3f5e4b5570ed2b294c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/mediatek/common/i2c.c M src/soc/mediatek/mt8183/spm.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/36454/1
diff --git a/src/soc/mediatek/common/i2c.c b/src/soc/mediatek/common/i2c.c index e58bb9c..1ca55ae 100644 --- a/src/soc/mediatek/common/i2c.c +++ b/src/soc/mediatek/common/i2c.c @@ -15,6 +15,7 @@
#include <string.h> #include <assert.h> +#include <console/console.h> #include <delay.h> #include <timer.h> #include <symbols.h> diff --git a/src/soc/mediatek/mt8183/spm.c b/src/soc/mediatek/mt8183/spm.c index 669970f..9a08782 100644 --- a/src/soc/mediatek/mt8183/spm.c +++ b/src/soc/mediatek/mt8183/spm.c @@ -15,6 +15,7 @@
#include <assert.h> #include <cbfs.h> +#include <console/console.h> #include <delay.h> #include <device/mmio.h> #include <endian.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36454 )
Change subject: soc/mediatek: Add missing '#include <console/console.h>' ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/common/i2c... File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/common/i2c... PS1, Line 37: printk it needs #include <console/console.h>
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/mt8183/spm... File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/mt8183/spm... PS1, Line 45: printk it needs #include <console/console.h>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36454 )
Change subject: soc/mediatek: Add missing '#include <console/console.h>' ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/common/i2c... File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/common/i2c... PS1, Line 37: printk
it needs #include <console/console. […]
Ack
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/mt8183/spm... File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/36454/1/src/soc/mediatek/mt8183/spm... PS1, Line 45: printk
it needs #include <console/console. […]
Ack
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36454 )
Change subject: soc/mediatek: Add missing '#include <console/console.h>' ......................................................................
soc/mediatek: Add missing '#include <console/console.h>'
Change-Id: I2e79ff3352fe974a070b7b3f5e4b5570ed2b294c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36454 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/mediatek/common/i2c.c M src/soc/mediatek/mt8183/spm.c 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/soc/mediatek/common/i2c.c b/src/soc/mediatek/common/i2c.c index e58bb9c..1ca55ae 100644 --- a/src/soc/mediatek/common/i2c.c +++ b/src/soc/mediatek/common/i2c.c @@ -15,6 +15,7 @@
#include <string.h> #include <assert.h> +#include <console/console.h> #include <delay.h> #include <timer.h> #include <symbols.h> diff --git a/src/soc/mediatek/mt8183/spm.c b/src/soc/mediatek/mt8183/spm.c index 669970f..9a08782 100644 --- a/src/soc/mediatek/mt8183/spm.c +++ b/src/soc/mediatek/mt8183/spm.c @@ -15,6 +15,7 @@
#include <assert.h> #include <cbfs.h> +#include <console/console.h> #include <delay.h> #include <device/mmio.h> #include <endian.h>
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)