Attention is currently required from: Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68195 )
Change subject: soc/amd/morgana: Add initial commit for new SoC ......................................................................
Patch Set 1:
(13 comments)
File src/soc/amd/morgana/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/31ff1fa6_3511b1f5 PS1, Line 32: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/622a9e81_37736256 PS1, Line 45: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
File src/soc/amd/morgana/psp_verstage/svc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/ffa18232_991a2a68 PS1, Line 12: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/24ec529b_f7c1f2eb PS1, Line 25: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/791f247d_3a0ddc52 PS1, Line 36: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/743c26b2_ce81faf8 PS1, Line 46: #define SVC_CALL1(SVC_ID, R0, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/1845ef2c_50df3ded PS1, Line 55: #define SVC_CALL0(SVC_ID, Ret) \ Macros with complex values should be enclosed in parentheses
File src/soc/amd/morgana/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/c4c374e8_48b29cff PS1, Line 87: * | | X86_RESET_VECTOR = BOOTBLOCK_END - 0x10 line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/fc11e137_280bce48 PS1, Line 90: * +--------------------------------+ BOOTBLOCK_ADDR = BOOTBLOCK_END - C_ENV_BOOTBLOCK_SIZE line length of 111 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/80e0503b_8ae0a710 PS1, Line 95: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE + 0x200 line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/2187db0d_aac5b10d PS1, Line 97: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE line length of 125 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/79fd9a56_4c388659 PS1, Line 100: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159925): https://review.coreboot.org/c/coreboot/+/68195/comment/8d80591a_b7fb05d9 PS1, Line 182: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB); line length of 97 exceeds 96 columns
-
build bot (Jenkins) (Code Review)