Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: romcc: cleanup leftovers ......................................................................
romcc: cleanup leftovers
Change-Id: I5112e0ce66e3bcd8c1f020089278766d2f27edb8 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M .gitignore M util/README.md M util/abuild/abuild.1 M util/lint/check_lint_tests M util/lint/lint-000-license-headers M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines M util/lint/lint-stable-010-asm-syntax 8 files changed, 2 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37968/1
diff --git a/.gitignore b/.gitignore index 0cc6ae2..86ddd19 100644 --- a/.gitignore +++ b/.gitignore @@ -115,7 +115,6 @@ util/nvramtool/nvramtool util/optionlist/Options.wiki util/pmh7tool/pmh7tool -util/romcc/build util/runfw/googlesnow util/superiotool/superiotool util/vgabios/testbios diff --git a/util/README.md b/util/README.md index 55bcaab..66438a9 100644 --- a/util/README.md +++ b/util/README.md @@ -86,8 +86,6 @@ * _sifive-gpt.py_ - Wraps the bootblock in a GPT partition for SiFive's bootrom. `Python3` * __rockchip__ - Generate Rockchip idblock bootloader. `Python2` -* __romcc__ - Compile a C source file generating a binary that does not -implicitly use RAM. `C` * __sconfig__ - coreboot device tree compiler `Lex` `Yacc` * __scripts__ * _config_ - Manipulate options in a .config file from the diff --git a/util/abuild/abuild.1 b/util/abuild/abuild.1 index 2eee84b..ccdfff6 100644 --- a/util/abuild/abuild.1 +++ b/util/abuild/abuild.1 @@ -78,7 +78,6 @@ .B abuild is covered by the GNU General Public License (GPL), version 2 or later. .SH SEE ALSO -.BR romcc (1), .BR flashrom (1). .SH COPYRIGHT 2004 Stefan Reinauer diff --git a/util/lint/check_lint_tests b/util/lint/check_lint_tests index 6b1860f..20d49a7 100755 --- a/util/lint/check_lint_tests +++ b/util/lint/check_lint_tests @@ -35,11 +35,6 @@ sed -i "s/for more details./for more details.\n * You${SPACE}should${SPACE}have received a copy of the GNU General Public License\n * along with this program; if not, write to the Free Software\n * Foundation, Inc./" ${TESTFILE009} git add ${TESTFILE009}
-#lint-stable-010-asm-syntax -TESTFILE010=src/arch/x86/bootblock_romcc.S -sed -i "1s/^/.att${UNDERSCORE}syntax noprefix\n/" ${TESTFILE010} -git add ${TESTFILE010} - #lint-stable-012-executable-bit TESTFILE012=src/lib/libgcc.c chmod +x ${TESTFILE012} diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index 9b3553b..5adbc7c 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -24,8 +24,6 @@ ^util/amdtools/example_input/|\ ^util/cbfstool/lzma/|\ ^util/kconfig/|\ -^util/romcc/tests|\ -^util/romcc/results|\ Kconfig|\ <COPYING>|\ <LICENSE>|\ diff --git a/util/lint/lint-014-qualified-types b/util/lint/lint-014-qualified-types index 98679ea..976748f 100755 --- a/util/lint/lint-014-qualified-types +++ b/util/lint/lint-014-qualified-types @@ -17,7 +17,7 @@ LC_ALL=C export LC_ALL
INCLUDED_DIRS='^src/|^util/|payloads/libpayload|payloads/coreinfo' -EXCLUDED_DIRS='^src/vendorcode|^util/romcc|cbfstool/lzma|cbfstool/lz4' +EXCLUDED_DIRS='^src/vendorcode|^util/cbfstool/lzma|cbfstool/lz4' INCLUDED_FILES='.[ch]:'
# Use git grep if the code is in a git repo, otherwise use grep. diff --git a/util/lint/lint-extended-015-final-newlines b/util/lint/lint-extended-015-final-newlines index b5a503f..15462d6 100755 --- a/util/lint/lint-extended-015-final-newlines +++ b/util/lint/lint-extended-015-final-newlines @@ -18,7 +18,7 @@
PIDS="" INCLUDED_DIRS_AND_FILES='util/* src/* payloads/* configs/* Makefile *.inc' -EXCLUDED_DIRS='src/vendorcode/|util/romcc/|cbfstool/lzma/|cbfstool/lz4/|Documentation/|build/|3rdparty/|.git/|coreboot-builds/|util/nvidia/cbootimage/' +EXCLUDED_DIRS='src/vendorcode/|util/cbfstool/lzma/|cbfstool/lz4/|Documentation/|build/|3rdparty/|.git/|coreboot-builds/|util/nvidia/cbootimage/' EXCLUDED_FILES='.jpg$|.cksum$|.bin$|.vbt$|.hex$|.ico$|.o$|.bz2$|.xz$|^.tmpconfig|.pyc$|_shipped$|sha256$|.png$|.patch$'
# Use git ls-files if the code is in a git repo, otherwise use find. diff --git a/util/lint/lint-stable-010-asm-syntax b/util/lint/lint-stable-010-asm-syntax index a102a77..e69de29 100755 --- a/util/lint/lint-stable-010-asm-syntax +++ b/util/lint/lint-stable-010-asm-syntax @@ -1,18 +0,0 @@ -#!/bin/sh -# This file is part of the coreboot project. -# -# Copyright 2016 Google Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# DESCR: Check that we use a single assembler syntax - -LC_ALL=C export LC_ALL -git grep -n ".(att|intel)_syntax>" | grep -v '.patch:'
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: romcc: cleanup leftovers ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37968/1/util/lint/check_lint_tests File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/37968/1/util/lint/check_lint_tests@... PS1, Line 35: sed -i "s/for more details./for more details.\n * You${SPACE}should${SPACE}have received a copy of the GNU General Public License\n * along with this program; if not, write to the Free Software\n * Foundation, Inc./" ${TESTFILE009} Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Hello Jacob Garber, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37968
to look at the new patch set (#2).
Change subject: romcc: cleanup leftovers ......................................................................
romcc: cleanup leftovers
Change-Id: I5112e0ce66e3bcd8c1f020089278766d2f27edb8 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M .gitignore M util/README.md M util/abuild/abuild.1 M util/lint/check_lint_tests M util/lint/lint-000-license-headers M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines D util/lint/lint-stable-010-asm-syntax 8 files changed, 2 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37968/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: romcc: cleanup leftovers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/check_lint_tests File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/check_lint_tests@... PS2, Line 35: sed -i "s/for more details./for more details.\n * You${SPACE}should${SPACE}have received a copy of the GNU General Public License\n * along with this program; if not, write to the Free Software\n * Foundation, Inc./" ${TESTFILE009} Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: romcc: cleanup leftovers ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: romcc: cleanup leftovers ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/lint-014-qualifie... File util/lint/lint-014-qualified-types:
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/lint-014-qualifie... PS2, Line 20: cbfstool util?
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/lint-extended-015... File util/lint/lint-extended-015-final-newlines:
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/lint-extended-015... PS2, Line 21: cbfstool if we canonicalize, maybe be consistent? (can be a follow up, too)
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/lint-stable-010-a... File util/lint/lint-stable-010-asm-syntax:
PS2: why remove this one? mixing asm syntaxes is still a pain, romcc or not.
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: romcc: cleanup leftovers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/check_lint_tests File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/37968/2/util/lint/check_lint_tests@... PS2, Line 41: git add ${TESTFILE010} I think the point of this script is to change existing files in a way to check that the lints fail. Since bootblock_romcc.S is gone, we could just change this to some other assembly file. There are a few other files that are now missing too (src/arch/ppc64/misc.c and src/mainboard/aaeon/pfm-540i_revb/board_info.txt), so I think it would make sense to update all of these in a separate commit.
Hello HAOUAS Elyes, Jacob Garber, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37968
to look at the new patch set (#3).
Change subject: git, util: romcc: cleanup leftovers ......................................................................
git, util: romcc: cleanup leftovers
Change-Id: I5112e0ce66e3bcd8c1f020089278766d2f27edb8 Signed-off-by: Idwer Vollering vidwer@gmail.com --- M .gitignore M util/README.md M util/abuild/abuild.1 M util/lint/check_lint_tests M util/lint/lint-000-license-headers M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines 7 files changed, 2 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/37968/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: git, util: romcc: cleanup leftovers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37968/3/util/lint/check_lint_tests File util/lint/check_lint_tests:
https://review.coreboot.org/c/coreboot/+/37968/3/util/lint/check_lint_tests@... PS3, Line 35: sed -i "s/for more details./for more details.\n * You${SPACE}should${SPACE}have received a copy of the GNU General Public License\n * along with this program; if not, write to the Free Software\n * Foundation, Inc./" ${TESTFILE009} Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: git, util: romcc: cleanup leftovers ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37968/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37968/3//COMMIT_MSG@7 PS3, Line 7: cleanup Verb is spelled with a space: Clean up.
Idwer Vollering has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37968 )
Change subject: git, util: romcc: cleanup leftovers ......................................................................
Abandoned
obsolete, see https://review.coreboot.org/c/coreboot/+/39116 and https://review.coreboot.org/c/coreboot/+/39075
-
build bot (Jenkins) (Code Review) -
HAOUAS Elyes (Code Review)
-
Idwer Vollering (Code Review)
-
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)