Change in ...coreboot[master]: mb/lenovo/r500: Add mainboard

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28644 )

Change subject: mb/lenovo/r500: Add mainboard
......................................................................


Patch Set 7: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/28644/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/28644/7//COMMIT_MSG@17 
PS7, Line 17: (Needs SeaBIOS with sercon disabled)
I think this isn't needed anymore


https://review.coreboot.org/#/c/28644/7//COMMIT_MSG@41 
PS7, Line 41: Debian 9, Linux 4.9
Was this booted via USB?


https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig 
File src/mainboard/lenovo/t400/Kconfig:

https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig@13 
PS7, Line 13: 	select BOARD_ROMSIZE_KB_8192
            : 	select BOARD_ROMSIZE_KB_4096 if BOARD_LENOVO_R500
Doesn't this conflict?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/28644
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e129b2e916acdf2b8534fa9d8d2cfc8f64f5815
Gerrit-Change-Number: 28644
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sun, 03 Feb 2019 17:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment