Attention is currently required from: Tim Wawrzynczak, Meera Ravindranath, Subrata Banik, Ronak Kanabar, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52730 )
Change subject: soc/alderlake: Fix DDR5 boot hang due to incorrect array size
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52730/comment/6b1e7146_5c99da2b
PS1, Line 10: of MRC channels.
Why? `struct spd_block` is independent of the interface used by MRC/FSP.
File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/52730/comment/0b7f6f06_59f43f04
PS1, Line 8: #include <soc/meminit.h>
Uh, this is backwards. Common code shouldn't depend on SoC-specific headers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e9c58f255bdf86a68ce90a4f853bf4e7c7ccfe
Gerrit-Change-Number: 52730
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 05 Sep 2021 16:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment