Attention is currently required from: Bao Zheng, Marshall Dawson, Zheng Bao, Matt Papageorge, Felix Held.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58555 )
Change subject: amdfwtool: Set soc name for Stoneyridge
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/58555/comment/03c86950_68d2bbd3
PS3, Line 1588: retval = set_efs_table(soc_id, amd_romsig, efs_spi_readmode,
Is efs not supported with stoneyridge (and so this behavior is as it should be) or is this just a precaution to keep the behavior the same even though you added a --soc argument to the command?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e82188ce64733420a578446e22a077ef789be92
Gerrit-Change-Number: 58555
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 01 Nov 2021 16:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment