Change in coreboot[master]: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
This change adds a JSON file (`global_lp4x_mem_parts.json.txt`) containing global list of LP4x memory parts to live along with the spd tools since the part information is not really any SoC or mainboard dependent and comes directly from the part datasheet. It can be shared by mainboards based on different platforms supported by the tools.
BUG=b:155239397,b:147321551
Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32 Signed-off-by: Furquan Shaikh furquan@google.com --- A util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 1 file changed, 114 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/41874/1
diff --git a/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt b/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt new file mode 100644 index 0000000..a9c13b0 --- /dev/null +++ b/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt @@ -0,0 +1,114 @@ +{ + "parts": [ + { + "name": "H9HCNNNBKMMLXR-NEE", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "H9HCNNNFAMMLXR-NEE", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 4, + "diesPerPackage": 8, + "bitWidthPerChannel": 8, + "ranksPerChannel": 2, + "speedMbps": 4267 + } + }, + { + "name": "K4U6E3S4AA-MGCL", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 1, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "K4UBE3D4AA-MGCL", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 2, + "speedMbps": 4267 + } + }, + { + "name": "MT53E1G32D2NP-046 WT:A", + "attribs": { + "densityPerChannelGb": 16, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "H9HKNNNCRMBVAR-NEH", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 4, + "diesPerPackage": 4, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "MT53E1G64D4SQ-046 WT:A", + "attribs": { + "densityPerChannelGb": 16, + "banks": 8, + "channelsPerDie": 4, + "diesPerPackage": 4, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "MT53E512M32D2NP-046 WT:F", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 1, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "NT6AP256T32AV-J2", + "attribs": { + "densityPerChannelGb": 4, + "banks": 8, + "channelsPerDie": 1, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 3733, + "tckMaxPs": 1250, + "casLatencies": "14 20 24 28 32" + } + } + ] +}
Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
This change adds a JSON file (`global_lp4x_mem_parts.json.txt`) containing global list of LP4x memory parts to live along with the spd tools since the part information is not really any SoC or mainboard dependent and comes directly from the part datasheet. It can be shared by mainboards based on different platforms supported by the tools.
BUG=b:155239397,b:147321551
Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32 Signed-off-by: Furquan Shaikh furquan@google.com --- A util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 1 file changed, 114 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/41874/2
Hello build bot (Jenkins), Shreesh Chhabbi, Ravishankar Sarawadi, Nick Vaccaro, Marco Chen, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41874
to look at the new patch set (#3).
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
This change adds a JSON file (`global_lp4x_mem_parts.json.txt`) containing global list of LP4x memory parts to live along with the spd tools since the part information is not really any SoC or mainboard dependent and comes directly from the part datasheet. It can be shared by mainboards based on different platforms supported by the tools.
BUG=b:155239397,b:147321551
Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32 Signed-off-by: Furquan Shaikh furquan@google.com --- A util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 1 file changed, 114 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/41874/3
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 112: } Furquan, can you add the following (needed for Volta/Voxel)?
{ "name": "H9HCNNNCPMMLXR-NEE", "attribs": { "densityPerChannelGb": 8, "banks": 8, "channelsPerDie": 2, "diesPerPackage": 4, "bitWidthPerChannel": 16, "ranksPerChannel": 2, "speedMbps": 4267 } }
Thanks !
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 33: 1 Should this be 2?
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 45: 2 Should this be 4?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 33: 1
Should this be 2?
No, this is the physical dies per package. So, it has to be 1. TGL MRC expects logical dies which is taken care of here: https://review.coreboot.org/c/coreboot/+/41612/14/util/spd_tools/intel/lp4x/...
channelsPerDie * ranksPerChannel * BitWidthPerChannel / 16 = 2 * 1 * 16 / 16 = 2
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 45: 2
Should this be 4?
Same as above: channelsPerDie * ranksPerChannel * BitWidthPerChannel / 16 = 2 * 2 * 16 / 16 = 4
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 112: }
Furquan, can you add the following (needed for Volta/Voxel)? […]
I already did that last night here: https://review.coreboot.org/c/coreboot/+/41989
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 33: 1
No, this is the physical dies per package. So, it has to be 1. […]
Done
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 45: 2
Same as above: […]
Thanks for the explanation. Is diesPerPackage only used to determine total size?
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 112: }
I already did that last night here: https://review.coreboot. […]
You rock !
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... File util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/41874/3/util/spd_tools/intel/lp4x/g... PS3, Line 45: 2
Thanks for the explanation. […]
It is helpful in calculating total size of physical package. But MRC doesn't really care about that. So, it goes unused on TGL. It is used on JSL though.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 4: Code-Review+2
Hello build bot (Jenkins), Shreesh Chhabbi, Ravishankar Sarawadi, Nick Vaccaro, Marco Chen, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41874
to look at the new patch set (#6).
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
This change adds a JSON file (`global_lp4x_mem_parts.json.txt`) containing global list of LP4x memory parts to live along with the spd tools since the part information is not really any SoC or mainboard dependent and comes directly from the part datasheet. It can be shared by mainboards based on different platforms supported by the tools.
BUG=b:155239397,b:147321551
Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32 Signed-off-by: Furquan Shaikh furquan@google.com --- A util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 1 file changed, 114 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/41874/6
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 8: Code-Review+1
Hello build bot (Jenkins), Shreesh Chhabbi, Ravishankar Sarawadi, Paul Menzel, Nick Vaccaro, Marco Chen, Aaron Durbin, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41874
to look at the new patch set (#9).
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
This change adds a JSON file (`global_lp4x_mem_parts.json.txt`) containing global list of LP4x memory parts to live along with the spd tools since the part information is not really any SoC or mainboard dependent and comes directly from the part datasheet. It can be shared by mainboards based on different platforms supported by the tools.
BUG=b:155239397,b:147321551
Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32 Signed-off-by: Furquan Shaikh furquan@google.com --- A util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 1 file changed, 114 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/41874/9
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 10: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 10: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts
This change adds a JSON file (`global_lp4x_mem_parts.json.txt`) containing global list of LP4x memory parts to live along with the spd tools since the part information is not really any SoC or mainboard dependent and comes directly from the part datasheet. It can be shared by mainboards based on different platforms supported by the tools.
BUG=b:155239397,b:147321551
Change-Id: I9e2f98fc9c1c8a7f73c9a1bfab22c996de222a32 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41874 Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt 1 file changed, 114 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Nick Vaccaro: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt b/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt new file mode 100644 index 0000000..5635158 --- /dev/null +++ b/util/spd_tools/intel/lp4x/global_lp4x_mem_parts.json.txt @@ -0,0 +1,114 @@ +{ + "parts": [ + { + "name": "H9HCNNNBKMMLXR-NEE", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 1, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "H9HCNNNFAMMLXR-NEE", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 4, + "diesPerPackage": 2, + "bitWidthPerChannel": 8, + "ranksPerChannel": 2, + "speedMbps": 4267 + } + }, + { + "name": "K4U6E3S4AA-MGCL", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 1, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "K4UBE3D4AA-MGCL", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 2, + "speedMbps": 4267 + } + }, + { + "name": "MT53E1G32D2NP-046 WT:A", + "attribs": { + "densityPerChannelGb": 16, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 1, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "H9HKNNNCRMBVAR-NEH", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "MT53E1G64D4SQ-046 WT:A", + "attribs": { + "densityPerChannelGb": 16, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "MT53E512M32D2NP-046 WT:F", + "attribs": { + "densityPerChannelGb": 8, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 1, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 4267 + } + }, + { + "name": "NT6AP256T32AV-J2", + "attribs": { + "densityPerChannelGb": 4, + "banks": 8, + "channelsPerDie": 2, + "diesPerPackage": 1, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 3733, + "tckMaxPs": 1250, + "casLatencies": "14 20 24 28 32" + } + } + ] +}
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41874 )
Change subject: util/spd_tools/intel/lp4x: Add a global list of LP4x memory parts ......................................................................
Patch Set 12:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5155 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5154 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5153 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5152
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)