Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30827 )
Change subject: mainboard/ocp/wedge100s: Fix uart
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30827/1/src/mainboard/ocp/wedge100s/romstage...
File src/mainboard/ocp/wedge100s/romstage.c:
https://review.coreboot.org/#/c/30827/1/src/mainboard/ocp/wedge100s/romstage...
PS1, Line 77: if (IS_ENABLED(CONFIG_FSP_USES_UPD)) {
What is this???
it makes FspRtBuffer.Common.UpdDataRgnPtr non NULL.
https://review.coreboot.org/#/c/30827/1/src/mainboard/ocp/wedge100s/romstage...
PS1, Line 96: }
yeah, moving this to the common code and making it dependent on !CONFIG_INTEGRATED_UART would be a g […]
That should probably be configured in common code depending on devicetree.cb. I don't like the CONFIG_INTEGRATED_UART option.
I'll do the cleanup in a separate commit, as this one only makes the serial work on wedge100s.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59cd83ed43dbf4ee26685e4a573de153291f7074
Gerrit-Change-Number: 30827
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrea Barberio
insomniac@slackware.it
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 08:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment