Change in ...coreboot[master]: QC common: fix compiler complaint, missing <string.h>
mturney mturney has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33445 Change subject: QC common: fix compiler complaint, missing <string.h> ...................................................................... QC common: fix compiler complaint, missing <string.h> Change-Id: I5b5b7bc61dd82fb1b866857d60926b057fae3715 Signed-off-by: T Michael Turney <mturney@codeaurora.org> --- M src/soc/qualcomm/common/qclib.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/33445/1 diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c index 73c5250..5df5b52 100644 --- a/src/soc/qualcomm/common/qclib.c +++ b/src/soc/qualcomm/common/qclib.c @@ -16,6 +16,7 @@ #include <console/cbmem_console.h> #include <cbmem.h> #include <boardid.h> +#include <string.h> #include <fmap.h> #include <assert.h> #include <arch/mmu.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/33445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b7bc61dd82fb1b866857d60926b057fae3715 Gerrit-Change-Number: 33445 Gerrit-PatchSet: 1 Gerrit-Owner: mturney mturney <mturney@qualcomm.corp-partner.google.com> Gerrit-MessageType: newchange
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33445 ) Change subject: QC common: fix compiler complaint, missing <string.h> ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/33445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b7bc61dd82fb1b866857d60926b057fae3715 Gerrit-Change-Number: 33445 Gerrit-PatchSet: 2 Gerrit-Owner: mturney mturney <mturney@qualcomm.corp-partner.google.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sat, 22 Jun 2019 04:38:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33445 ) Change subject: QC common: fix compiler complaint, missing <string.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b7bc61dd82fb1b866857d60926b057fae3715 Gerrit-Change-Number: 33445 Gerrit-PatchSet: 3 Gerrit-Owner: mturney mturney <mturney@qualcomm.corp-partner.google.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sat, 29 Jun 2019 18:02:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33445 ) Change subject: QC common: fix compiler complaint, missing <string.h> ...................................................................... QC common: fix compiler complaint, missing <string.h> Change-Id: I5b5b7bc61dd82fb1b866857d60926b057fae3715 Signed-off-by: T Michael Turney <mturney@codeaurora.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33445 Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M src/soc/qualcomm/common/qclib.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c index 25512a9..ac80a76 100644 --- a/src/soc/qualcomm/common/qclib.c +++ b/src/soc/qualcomm/common/qclib.c @@ -16,6 +16,7 @@ #include <console/cbmem_console.h> #include <cbmem.h> #include <boardid.h> +#include <string.h> #include <fmap.h> #include <assert.h> #include <arch/mmu.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/33445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b7bc61dd82fb1b866857d60926b057fae3715 Gerrit-Change-Number: 33445 Gerrit-PatchSet: 4 Gerrit-Owner: mturney mturney <mturney@qualcomm.corp-partner.google.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (3)
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
mturney mturney (Code Review)