[M] Change in coreboot[master]: mb/google/geralt: Fix MIPI panel power on/off sequence - coreboot-gerrit

1 Jun 2023


      Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Yidi Lin, Yu-Ping Wu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75512?usp=email )
Change subject: mb/google/geralt: Fix MIPI panel power on/off sequence
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/75512/comment/503dff7e_bb0c65ef :
PS3, Line 51: 		printk(BIOS_ERR, "Failed to setup tps65132s\n");
...
Error messages should be user understandable. Maybe: […]
TPS65132 isn't a display panel, but a voltage regulator
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75512?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ccb5be04062a0516f84a054ff3f40afbf5279be
Gerrit-Change-Number: 75512
Gerrit-PatchSet: 3
Gerrit-Owner: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 13:10:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment