Attention is currently required from: Subrata Banik, Angel Pons, Lean Sheng Tan, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71575 )
Change subject: soc/intel/alderlake: Disable Intel TXT
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71575/comment/c2bcfaa5_a5c2f67f
PS6, Line 8:
… for framebuffer access
https://review.coreboot.org/c/coreboot/+/71575/comment/fdb263c2_040badcc
PS6, Line 10:
Please add a problem description, why disabling TXT might be useful.
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/71575/comment/dca89924_0658d4f8
PS6, Line 142: * It would help to access VGA framebuffer prior calling into FSP-M
Please add a dot/period at the end of sentences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71575
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dd7c5492a5f45eef0dd9e836cc2da1844c78919
Gerrit-Change-Number: 71575
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sat, 07 Jan 2023 08:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment