[XS] Change in coreboot[master]: mb/system76/adl: Remove PL4 values

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75333?usp=email )

Change subject: mb/system76/adl: Remove PL4 values
......................................................................

mb/system76/adl: Remove PL4 values

System76 EC since system76/ec@99dfbeaec3b8 sets PL4 values through PECI
based on AC state for all boards. Remove the static PL4 values from
coreboot since they won't be used.

Ref: https://github.com/system76/ec/pull/353
Change-Id: I66bc547ef1b3419fc677fcbdd5ba5d8cc8e14189
Signed-off-by: Tim Crawford 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75333
Reviewed-by: Jeremy Soller 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/system76/adl/variants/darp8/overridetree.cb
M src/mainboard/system76/adl/variants/galp6/overridetree.cb
M src/mainboard/system76/adl/variants/lemp11/overridetree.cb
M src/mainboard/system76/adl/variants/oryp10/overridetree.cb
M src/mainboard/system76/adl/variants/oryp9/overridetree.cb
5 files changed, 0 insertions(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Jeremy Soller: Looks good to me, approved

diff --git a/src/mainboard/system76/adl/variants/darp8/overridetree.cb b/src/mainboard/system76/adl/variants/darp8/overridetree.cb
index a4dbed8..91b0291 100644
--- a/src/mainboard/system76/adl/variants/darp8/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/darp8/overridetree.cb
@@ -1,10 +1,7 @@
 chip soc/intel/alderlake
-	# HACK: Limit PL4 to PL2 to prevent power-off when system is booted on
-	# battery power. This seems to only happen with the i7 units.
    register "power_limits_config[ADL_P_282_442_482_28W_CORE]" = "{
    	.tdp_pl1_override = 20,
    	.tdp_pl2_override = 56,
-		.tdp_pl4 = 56, // FIXME: Set to 65
    }"

# GPE configuration
diff --git a/src/mainboard/system76/adl/variants/galp6/overridetree.cb b/src/mainboard/system76/adl/variants/galp6/overridetree.cb
index cac4df6..dc5d593 100644
--- a/src/mainboard/system76/adl/variants/galp6/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/galp6/overridetree.cb
@@ -2,7 +2,6 @@
    register "power_limits_config[ADL_P_282_442_482_28W_CORE]" = "{
    	.tdp_pl1_override = 28,
    	.tdp_pl2_override = 60,
-		.tdp_pl4 = 90,
    }"

# GPE configuration
diff --git a/src/mainboard/system76/adl/variants/lemp11/overridetree.cb b/src/mainboard/system76/adl/variants/lemp11/overridetree.cb
index 82943cb..379dad8 100644
--- a/src/mainboard/system76/adl/variants/lemp11/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/lemp11/overridetree.cb
@@ -2,7 +2,6 @@
    register "power_limits_config[ADL_P_142_242_282_15W_CORE]" = "{
    	.tdp_pl1_override = 15,
    	.tdp_pl2_override = 46,
-		.tdp_pl4 = 65,
    }"

# GPE configuration
diff --git a/src/mainboard/system76/adl/variants/oryp10/overridetree.cb b/src/mainboard/system76/adl/variants/oryp10/overridetree.cb
index ddf5876..ad75a13 100644
--- a/src/mainboard/system76/adl/variants/oryp10/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/oryp10/overridetree.cb
@@ -1,10 +1,8 @@
 chip soc/intel/alderlake
-	# HACK: Limit PL4 to prevent power off on battery power.
    register "power_limits_config[ADL_P_642_682_45W_CORE]" = "{
    	.tdp_pl1_override = 45,
    	.tdp_pl2_override = 115,
    	.tdp_psyspl2 = 135,
-		.tdp_pl4 = 72,
    }"

# Thermal
diff --git a/src/mainboard/system76/adl/variants/oryp9/overridetree.cb b/src/mainboard/system76/adl/variants/oryp9/overridetree.cb
index a58c4c3..13989cb 100644
--- a/src/mainboard/system76/adl/variants/oryp9/overridetree.cb
+++ b/src/mainboard/system76/adl/variants/oryp9/overridetree.cb
@@ -1,10 +1,8 @@
 chip soc/intel/alderlake
-	# HACK: Limit PL4 to prevent power off on battery power.
    register "power_limits_config[ADL_P_642_682_45W_CORE]" = "{
    	.tdp_pl1_override = 45,
    	.tdp_pl2_override = 115,
    	.tdp_psyspl2 = 135,
-		.tdp_pl4 = 72,
    }"

# Thermal