Attention is currently required from: Arthur Heymans, Felix Held, Michał Żygowski.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76278?usp=email )
Change subject: nb/pi/00730F01: Rework nb resource reading ......................................................................
Patch Set 5:
(1 comment)
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/76278/comment/a8966c14_707d8024 : PS5, Line 113: *limit += (1 << 24); /* Make the limit inclusive */
expected that a -1 was missing there, but it's correct for the functions that will be called further […]
I may be able to recover and complete topic:new-resource, bring it on the table there.
We should discuss how to better describe memory layout already at the end of romstage (for traditional x86) or at reset (PSP raminit). The way DRAM wiping currently works is a bit hacky.
-
Kyösti Mälkki (Code Review)