Attention is currently required from: Raul Rangel, Furquan Shaikh, Angel Pons, Karthik Ramasubramanian. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56580 )
Change subject: commonlib/mem_pool: Allow configuring the alignment ......................................................................
Patch Set 9: Code-Review+2
(2 comments)
File src/commonlib/include/commonlib/mem_pool.h:
https://review.coreboot.org/c/coreboot/+/56580/comment/b78cf124_7fc49b86 PS7, Line 59: mp->alignment = alignment;
assert is a coreboot thing isn't it?
No, I'd say it's a libc thing and you can expect it to be available here (from <assert.h>). We have other assert()s in commonlib already.
https://review.coreboot.org/c/coreboot/+/56580/comment/db6d0287_3c649fe4 PS7, Line 65: 0
Done. I just added a parameter and updated the callers.
commonlib isn't really meant to be used by out-of-tree sources, I don't think you need to care about that. It's just for sharing code between coreboot, all the stuff in the util/ directory, and hopefully soon libpayload.
-
Julius Werner (Code Review)