Change in coreboot[master]: mb/google/brya/variants/taeko: Configure GPIOs according to schematics
Attention is currently required from: Tim Wawrzynczak, Paul Menzel. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56754 )
Change subject: mb/google/brya/variants/taeko: Configure GPIOs according to schematics ......................................................................
Patch Set 8:
(9 comments)
File src/mainboard/google/brya/variants/taeko/gpio.c:
https://review.coreboot.org/c/coreboot/+/56754/comment/11ba729b_71e10664 PS7, Line 18: UP_20K
`PAD_CFG_GPO` does not take a pullup/pulldown value, should this be: […]
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/f57ce39b_d967f5bd PS7, Line 38: UP_20K
Is the AUD_HP_INT_L on MLB or a DB?
This is on MLB
https://review.coreboot.org/c/coreboot/+/56754/comment/a44aac90_71f55924 PS7, Line 45: UP_20K
remove
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/09c133c1_1335c9be PS7, Line 50: UP_20K
remove
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/9ff2972e_440ee8f0 PS7, Line 59: UP_20K
remove
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/4a857f24_286325f4 PS7, Line 63: UP_20K
remove
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/7388b9ff_8acfafe1 PS7, Line 81: UP_20K
remove
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/dcd2d2b2_6d6fed3e PS7, Line 90: UP_20K
remove
Done
https://review.coreboot.org/c/coreboot/+/56754/comment/a4100b85_2fc66c94 PS7, Line 92: UP_20K
remove
Done
-
Joey Peng (Code Review)