Change in coreboot[master]: cpu/x86/smm_module_handler: Add relocatable module params - coreboot-gerrit

16 Mar 2021


      Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50764 )
Change subject: cpu/x86/smm_module_handler: Add relocatable module params
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/50764/comment/d1acc34c_4df8bb89 
PS1, Line 401: 	handler_mod_params->gnvs_ptr = (uintptr_t)acpi_get_gnvs();
...
...
Were these parameters not set before? Or am I missing something? […]
Ack
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3bde78dd9e0c02dd1d86e03665fa9c65e3d07eb
Gerrit-Change-Number: 50764
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 16 Mar 2021 12:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment