Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47054 )
Change subject: mb/intel/adlrvp: Replace if-else-if ladder with switch construct
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/47054/2/src/mainboard/intel/adlrvp/...
PS2, Line 76: case ADL_P_LP4_1:
Because missing a 'break' (or return, etc.) in switch statements is a common mistake, I like to add
`/* intentional fallthrough */`
to the end of fallthrough cases.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I268db8bc63aaf64d4a91c9a44ef5282154b20a53
Gerrit-Change-Number: 47054
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Comment-Date: Mon, 02 Nov 2020 21:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment