Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34998 )
Change subject: vendorcode/cavium: Replace use of __PRE_RAM__
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34998/11/src/vendorcode/cavium/bdk/...
File src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c:
https://review.coreboot.org/c/coreboot/+/34998/11/src/vendorcode/cavium/bdk/...
PS11, Line 208:
Maybe it should be spaces instead of tabs? […]
Now that __PRE_RAM__ tests inside set_value() were removed, it would need malloc(). Maybe it would link without the conditional here, but this maintains the old behaviour.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34998
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c93031c8c0e3a86261988edc956e8cd5a8dd961
Gerrit-Change-Number: 34998
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Sep 2019 12:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment