Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85238?usp=email )
Change subject: soc/amd/common/psp/psp_smi: report errors in 'handle_psp_command' ......................................................................
soc/amd/common/psp/psp_smi: report errors in 'handle_psp_command'
To see if things went wrong in the 'handle_psp_command' function, print the status code in case it's not MBOX_PSP_SUCCESS.
Change-Id: I8c02e8e29ab5619282e5b864a8cea6f0703f6ef2 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/psp/psp_smi.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/85238/1
diff --git a/src/soc/amd/common/block/psp/psp_smi.c b/src/soc/amd/common/block/psp/psp_smi.c index 5a1a4b9..762c8ee 100644 --- a/src/soc/amd/common/block/psp/psp_smi.c +++ b/src/soc/amd/common/block/psp/psp_smi.c @@ -173,6 +173,9 @@
if (status == MBOX_PSP_SUCCESS && rd_bios_mbox_checksum_en()) wr_bios_mbox_checksum(calc_psp_buffer_checksum8()); + + if (status != MBOX_PSP_SUCCESS) + printk(BIOS_ERR, "PSP: SMI processing error. staus code %#x\n", status); }
/* TODO: check if all wbinvd() calls are necessary */