Change in coreboot[master]: mb/google/brya: Enable WFC - coreboot-gerrit

1 Jun 2021


      Attention is currently required from: Varshit B Pandya, Furquan Shaikh, Rizwan Qureshi, Meera Ravindranath, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52013 )
Change subject: mb/google/brya: Enable WFC
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52013/comment/d6a7a0ed_022c4a4e 
PS3, Line 188: register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)"
...
to be frank I have not tried this sequence, the data sheet suggested to bring the sensor out of Rese […]
This does seem OK with the datasheet.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5e9c28f255bdf86a68ce80a4f853be4e7c7ccfe
Gerrit-Change-Number: 52013
Gerrit-PatchSet: 9
Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Varshit B Pandya varshit.b.pandya@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sanju Jose Thottan sanjujose.thottan@intel.com
Gerrit-CC: Shobhit Srivastava shobhit.srivastava@intel.com
Gerrit-CC: V Sowmya v.sowmya@intel.com
Gerrit-Attention: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Attention: Varshit B Pandya varshit.b.pandya@intel.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com
Gerrit-Attention: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 21:36:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya varshit.b.pandya@intel.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment