Change in coreboot[master]: mb/dell: Add Dell Optiplex 790

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21774 )

Change subject: mb/dell: Add Dell Optiplex 790
......................................................................


Patch Set 60:

(1 comment)

https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... 
File src/mainboard/dell/optiplex_790/romstage.c:

https://review.coreboot.org/c/coreboot/+/21774/60/src/mainboard/dell/optiple... 
PS60, Line 17: 
             : #include <stdint.h>
             : #include <string.h>
             : #include <timestamp.h>
             : #include <arch/byteorder.h>
             : #include <arch/io.h>
             : #include <device/mmio.h>
             : #include <device/pci_ops.h>
             : #include <device/pnp_ops.h>
             : #include <cpu/x86/lapic.h>
             : #include <console/console.h>
             : #include <northbridge/intel/sandybridge/sandybridge.h>
             : #include <northbridge/intel/sandybridge/raminit_native.h>
             : #include <southbridge/intel/bd82x6x/pch.h>
             : #include <southbridge/intel/common/gpio.h>
include only what you use.
please remove unused includes



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/21774
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f
Gerrit-Change-Number: 21774
Gerrit-PatchSet: 60
Gerrit-Owner: Christoph Pomaska <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Christoph Pomaska <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Jonathan Neuschäfer <[e-mail]>
Gerrit-Reviewer: Kyösti Mälkki <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Mimoja <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: HAOUAS Elyes <[e-mail]>
Gerrit-CC: Thomas Heijligen <[e-mail]>
Gerrit-Comment-Date: Mon, 03 Feb 2020 16:55:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment