Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt Papageorge, Felix Held. Jason Nein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58803 )
Change subject: vc/amd/agesa: fix out-of-bounds read ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58803/comment/ea9546b6_858c9069 PS1, Line 7: src/vendorcode/amd : Zork, MI: Bug in AGESA FabricResourceManagerUnbLib.c
coreboot has a couple of references for how to write a good commit message although none are really […]
Done
https://review.coreboot.org/c/coreboot/+/58803/comment/64d4bf99_89d3186b PS1, Line 9: Fixing coverity issues: Out-of-bounds read
Make sure you use complete sentences and that your verbs are imperative, e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/58803/comment/63d6daf5_191cc73a PS1, Line 11: BUG=b:147411796
This doesn't really apply for Trinity and Kabini changes. You could omit it.
Done
https://review.coreboot.org/c/coreboot/+/58803/comment/c6f42925_1897ae77 PS1, Line 12: Build pass and run the normal boot on Guybrush
Guybrush doesn't use this code. […]
Done
File src/vendorcode/amd/agesa/f15tn/Proc/CPU/Family/0x15/cpuF15MmioMap.c:
https://review.coreboot.org/c/coreboot/+/58803/comment/94520295_1febd711 PS1, Line 232: 12
Is there a defined value somewhere that can be used instead of 12?
Done
-
Jason Nein (Code Review)