Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45767 )
Change subject: mb/ocp/tiogapass/dsdt: Remove unnecessary comments ......................................................................
mb/ocp/tiogapass/dsdt: Remove unnecessary comments
Change-Id: I6a16e2f829219f2eba8acd3ae7f371238c0d8de1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/ocp/tiogapass/dsdt.asl 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/45767/1
diff --git a/src/mainboard/ocp/tiogapass/dsdt.asl b/src/mainboard/ocp/tiogapass/dsdt.asl index 78475e0..677d2ca 100644 --- a/src/mainboard/ocp/tiogapass/dsdt.asl +++ b/src/mainboard/ocp/tiogapass/dsdt.asl @@ -11,12 +11,8 @@ 0x20110725 // OEM revision ) { - // platform ACPI tables #include "acpi/platform.asl" - - // global NVS and variables #include <soc/intel/xeon_sp/skx/acpi/globalnvs.asl> - #include <cpu/intel/common/acpi/cpu.asl> #include <soc/intel/xeon_sp/skx/acpi/uncore.asl> }
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45767 )
Change subject: mb/ocp/tiogapass/dsdt: Remove unnecessary comments ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Marc Jones,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45767
to look at the new patch set (#3).
Change subject: mb/ocp/tiogapass/dsdt: Remove unnecessary comments ......................................................................
mb/ocp/tiogapass/dsdt: Remove unnecessary comments
Change-Id: I6a16e2f829219f2eba8acd3ae7f371238c0d8de1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/ocp/tiogapass/dsdt.asl 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/45767/3
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45767 )
Change subject: mb/ocp/tiogapass/dsdt: Remove unnecessary comments ......................................................................
Patch Set 3: Code-Review+2
Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45767 )
Change subject: mb/ocp/tiogapass/dsdt: Remove unnecessary comments ......................................................................
mb/ocp/tiogapass/dsdt: Remove unnecessary comments
Change-Id: I6a16e2f829219f2eba8acd3ae7f371238c0d8de1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45767 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marc Jones marc@marcjonesconsulting.com --- M src/mainboard/ocp/tiogapass/dsdt.asl 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved
diff --git a/src/mainboard/ocp/tiogapass/dsdt.asl b/src/mainboard/ocp/tiogapass/dsdt.asl index d5b7b42..ddc7160 100644 --- a/src/mainboard/ocp/tiogapass/dsdt.asl +++ b/src/mainboard/ocp/tiogapass/dsdt.asl @@ -11,12 +11,8 @@ 0x20110725 // OEM revision ) { - // platform ACPI tables #include "acpi/platform.asl" - - // global NVS and variables #include <soc/intel/xeon_sp/acpi/globalnvs.asl> - #include <cpu/intel/common/acpi/cpu.asl> #include <soc/intel/xeon_sp/acpi/uncore.asl> }
-
Marc Jones (Code Review) -
Maxim Polyakov (Code Review)