Change in coreboot[master]: util/cbfstool/lzma: Make clang-11+'s indentation checker happy

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Georgi (Code Review)

29 Jan 2020 29 Jan '20

9:03 p.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

util/cbfstool/lzma: Make clang-11+'s indentation checker happy

Newest clang compilers warn about "misleading indentation", and because warnings-are-errors in our builds, that breaks the build.

The lzma code base is vendored in, so we might just have to update it, but that's a bigger effort than just removing a couple of spaces (the coding style of the file is horrible, but I will only change it as much as the compilers ask for).

BUG=chromium:1039526

Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/cbfstool/lzma/C/LzmaEnc.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/38637/1

diff --git a/util/cbfstool/lzma/C/LzmaEnc.c b/util/cbfstool/lzma/C/LzmaEnc.c index e7d14c5..f2a8320 100644 --- a/util/cbfstool/lzma/C/LzmaEnc.c +++ b/util/cbfstool/lzma/C/LzmaEnc.c @@ -1246,7 +1246,7 @@ startLen = lenTest + 1;

/* if (_maxMode) */ - { + { uint32_t lenTest2 = lenTest + 1; uint32_t limit = lenTest2 + p->numFastuint8_ts; uint32_t nextRepMatchPrice; @@ -1290,7 +1290,7 @@ } } } - } + } } } /* for (uint32_t lenTest = 2; lenTest <= newLen; lenTest++) */

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

build bot (Jenkins) (Code Review)

29 Jan 29 Jan

9:03 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38637/1/util/cbfstool/lzma/C/LzmaEn... File util/cbfstool/lzma/C/LzmaEnc.c:

https://review.coreboot.org/c/coreboot/+/38637/1/util/cbfstool/lzma/C/LzmaEn... PS1, Line 1249: { please, no spaces at the start of a line

https://review.coreboot.org/c/coreboot/+/38637/1/util/cbfstool/lzma/C/LzmaEn... PS1, Line 1293: } please, no spaces at the start of a line

-- To view, visit https://review.coreboot.org/c/coreboot/+/38637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Gerrit-Change-Number: 38637 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-CC: Name of user not set #1000432 Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 29 Jan 2020 20:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:03 p.m.

Patrick Georgi has removed Name of user not set #1000432 from this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

Removed reviewer null.

Stefan Reinauer (Code Review)

30 Jan 30 Jan

9:48 a.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Gerrit-Change-Number: 38637 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 Jan 2020 08:48:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:18 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Gerrit-Change-Number: 38637 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 Jan 2020 10:18:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Idwer Vollering (Code Review)

11:50 a.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

Patch Set 1: Code-Review+2

clang (llvm, actually) <3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Gerrit-Change-Number: 38637 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 Jan 2020 10:50:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

31 Jan 31 Jan

12:23 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38637/1/util/cbfstool/lzma/C/LzmaEn... File util/cbfstool/lzma/C/LzmaEnc.c:

https://review.coreboot.org/c/coreboot/+/38637/1/util/cbfstool/lzma/C/LzmaEn... PS1, Line 1249: {

...

please, no spaces at the start of a line

*smacks Jenkins with a broom*

-- To view, visit https://review.coreboot.org/c/coreboot/+/38637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Gerrit-Change-Number: 38637 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 Jan 2020 23:23:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1 Feb 1 Feb

8:51 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38637 )

Change subject: util/cbfstool/lzma: Make clang-11+'s indentation checker happy ......................................................................

util/cbfstool/lzma: Make clang-11+'s indentation checker happy

Newest clang compilers warn about "misleading indentation", and because warnings-are-errors in our builds, that breaks the build.

BUG=chromium:1039526

Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38637 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Idwer Vollering vidwer@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/cbfstool/lzma/C/LzmaEnc.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Idwer Vollering: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/38637 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9d7a760380081af996ea5412d7e3e688048bfd Gerrit-Change-Number: 38637 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1543

days inactive

1546

days old

coreboot-gerrit@coreboot.org

7 comments

6 participants

tags (0)

participants (6)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Idwer Vollering (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)