Attention is currently required from: Christian Walter, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
......................................................................
Patch Set 72:
(1 comment)
File Documentation/mainboard/supermicro/x11-lga1151v2-series/x11sch-f/x11sch-f.md:
https://review.coreboot.org/c/coreboot/+/37441/comment/d6aa5a83_a652f46e
PS64, Line 31: 0x235=03 and 0x13E=84
I remember reading somewhere that these offsets seem to be wrong. I haven't checked them myself.
I have no access to the CNP SPI programming guide, however, building enabled/disabled images with FIT and comparing revealed these offsets:
- 0x234 : en/dis (0/1) <- latest image from Supermicro has this set already
^-- 4, not 5
- 0x13D : frequency, 0x06 = 17 MHz, 0x02 = 48 MHz
^-- D, not E
So.... where do your offset/value pairs come from?
Also, according to the product page, it's a Infineon 9670 TPM, which only supports a maximum of 48 MHz according to its datasheet. While 48 MHz might work on your specific TPM does not mean that it will work on anyone's.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30
Gerrit-Change-Number: 37441
Gerrit-PatchSet: 72
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Jonas Löffelholz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 05 Jan 2022 16:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Walter
christian.walter@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment