build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28293 )
Change subject: util/romcc: Fix typos ......................................................................
Patch Set 1:
(22 comments)
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c File util/romcc/romcc.c:
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@1770 PS1, Line 1770: for(spot = triple->occurrence; spot; spot = spot->parent) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@1952 PS1, Line 1952: if (occurrence->parent) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@2403 PS1, Line 2403: piece = alloc_triple(state, OP_PIECE, piece_type, -1, -1, ins->occurrence); line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@2522 PS1, Line 2522: for(ptr = ins->occurrence; ptr; ptr = ptr->parent) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@2605 PS1, Line 2605: for(ptr = orig->occurrence; ptr; ptr = ptr->parent) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@13722 PS1, Line 13722: occurrence = inline_occurrence(state, base_occurrence, old->occurrence); line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@15918 PS1, Line 15918: while(ins != block->last && (ins->occurrence->line == 0)) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@15918 PS1, Line 15918: while(ins != block->last && (ins->occurrence->line == 0)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@16628 PS1, Line 16628: phi->type, 0, 0, phi->occurrence)); line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@20782 PS1, Line 20782: #warning "FIXME constant propagate through expressions with multiple left hand sides" line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@21479 PS1, Line 21479: if ( (dummy_occurrence.count != 2) || space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@21484 PS1, Line 21484: internal_error(state, &unknown_triple, "dummy_occurrence corrupted!"); line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24821 PS1, Line 24821: ins->occurrence->function?ins->occurrence->function:"(null)", line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24822 PS1, Line 24822: ins->occurrence->filename?ins->occurrence->filename:"(null)", line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24831 PS1, Line 24831: for(ptr = ins->occurrence; ptr; ptr = ptr->parent) { line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24831 PS1, Line 24831: for(ptr = ins->occurrence; ptr; ptr = ptr->parent) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28293/1/util/romcc/romcc.c@24844 PS1, Line 24844: if (last_occurrence) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/linux_test2.c File util/romcc/tests/linux_test2.c:
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/linux_test2.c@487 PS1, Line 487: * This field defines the upp address bits of a 40-bit address that line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test.c File util/romcc/tests/raminit_test.c:
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test.c@757 PS1, Line 757: * DRAMC register, which records if ram is registered or not, line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test1.c File util/romcc/tests/raminit_test1.c:
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test1.c@757 PS1, Line 757: * DRAMC register, which records if ram is registered or not, line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test2.c File util/romcc/tests/raminit_test2.c:
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/raminit_test2.c@757 PS1, Line 757: * DRAMC register, which records if ram is registered or not, line over 80 characters
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/simple_test30.c File util/romcc/tests/simple_test30.c:
https://review.coreboot.org/#/c/28293/1/util/romcc/tests/simple_test30.c@901 PS1, Line 901: * This field defines the upp address bits of a 40-bit address that line over 80 characters
-
build bot (Jenkins) (Code Review)