Attention is currently required from: Eran Mitrani, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78653?usp=email )
Change subject: soc/intel/meteorlake: Adjust Power State Current 2 threshold
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/78653/comment/d4af9902_3d76be50 :
PS2, Line 291: power_state_current1_threshold
nit: ps_cur_1_threshold?
Done
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/78653/comment/9cb5306d_bcb80457 :
PS2, Line 243: power_state_current1_threshold
with ```ps_cur_1_threshold```, it can fit in the line above IMO
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78653?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2da2b05de8a04f91dacaa55062165c4351422865
Gerrit-Change-Number: 78653
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 04:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment