Attention is currently required from: Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Maximilian Brune, Paul Menzel.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84574?usp=email )
Change subject: soc/amd/.../amd_pci_int_defs.h: Update according to datasheet
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Patchset:
PS4:
apart from the open comment about the register names in the commit message, this looks god to me
Commit Message:
https://review.coreboot.org/c/coreboot/+/84574/comment/76fb6760_6df76bb5?usp... :
PS4, Line 9: MISC2/3
1/2 or is my math wrong? Otherwise the patch LGTM.
yes, MISC1 and MISC2. those 4 registers are counted in a really weird way though: MISC, MISC0, MISC1 and MISC2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64f685e507e1cd5ee90e1b18526b9d59ed4c1b34
Gerrit-Change-Number: 84574
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 02 Oct 2024 11:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com