Attention is currently required from: YH Lin, Joey Peng, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59938 )
Change subject: mb/google/brya/variants/taniks: Configure GPIOs according to schematics
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59938/comment/a89679ad_e0e517de
PS4, Line 9: Update
Add?
https://review.coreboot.org/c/coreboot/+/59938/comment/f9ab73c1_14b2657a
PS4, Line 10:
Which schematics version is that? Please add it to the commit message.
File src/mainboard/google/brya/variants/taniks/gpio.c:
https://review.coreboot.org/c/coreboot/+/59938/comment/daeae087_2e96a137
PS4, Line 153: * FPMCU not working after a S3 resume. This is a known issue.
Is there a bug report for that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c4ead4ad59137e1764e1226415ab6041c68aab
Gerrit-Change-Number: 59938
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 10:52:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment