Attention is currently required from: Jamie Chen, Kane Chen, Nick Vaccaro, Simon Yang, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79370?usp=email )
Change subject: soc/intel/alderlake: add pcie modphy settings ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79370/comment/1bda0ece_c9f35461 : PS2, Line 7: add pcie modphy settings Allow to tune PCIe modphy settings
https://review.coreboot.org/c/coreboot/+/79370/comment/066f044a_2cfea26f : PS2, Line 8: Please start by summarizing the problem, and why tuning PCIe modphy is useful.
https://review.coreboot.org/c/coreboot/+/79370/comment/c4a2b48d_3af5be24 : PS2, Line 14: enable enabled
File src/soc/intel/alderlake/include/soc/pcie_modphy.h:
https://review.coreboot.org/c/coreboot/+/79370/comment/4cdd0834_fa95246c : PS2, Line 7: /* TX Output Downscale Amplitude Adjustment */ : bool tx_gen1_downscale_amp_override; : uint8_t tx_gen1_downscale_amp; : /* TX Output Downscale Amplitude Adjustment */ : bool tx_gen2_downscale_amp_override; : uint8_t tx_gen2_downscale_amp; : /* TX Output Downscale Amplitude Adjustment */ The three comments are identical?