Attention is currently required from: Marshall Dawson, Paul Menzel, Zheng Bao. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55602 )
Change subject: amdfwtool: Update and extend PSP header format description ......................................................................
Patch Set 12:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55602/comment/78a3e655_76e8bd6d PS11, Line 7: Add more detailed description and note in comment
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/55602/comment/b1886ea9_db61028b PS11, Line 8:
Why is the update needed? Was newer documentation released?
Done
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/55602/comment/a6b8a1bd_af7f8287 PS11, Line 4: (*)
What does this mean?
Done
https://review.coreboot.org/c/coreboot/+/55602/comment/1215de99_2b3c679a PS11, Line 31: Firmwares
I think plural is also *firmware*.
Done
https://review.coreboot.org/c/coreboot/+/55602/comment/0ad7a325_4e2287b9 PS11, Line 49: Firmwares
Firmware
Done
https://review.coreboot.org/c/coreboot/+/55602/comment/8cfd422d_987e2928 PS11, Line 53: BIOS Directory Table(BDT)
Please add a space before the (.
Done
-
Bao Zheng (Code Review)