Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15965
-gerrit
commit f14d417a597091b581710e5dec1ce98a414c81f3 Author: Patrick Georgi pgeorgi@chromium.org Date: Fri Jul 29 18:53:34 2016 +0200
intel/broadwell: fix typo
(pci_read_config32(...) > 14) & 0x3 looks rather unusual (and prevents "case 3" below from ever happening)
Change-Id: Id90655c39ff53da9569441278bbf73497d643480 Signed-off-by: Patrick Georgi pgeorgi@chromium.org Found-by: Coverity Scan #1293139 --- src/soc/intel/broadwell/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/broadwell/pcie.c b/src/soc/intel/broadwell/pcie.c index 41d66e2..1c9b50c 100644 --- a/src/soc/intel/broadwell/pcie.c +++ b/src/soc/intel/broadwell/pcie.c @@ -99,7 +99,7 @@ static void root_port_config_update_gbe_port(void) static void pcie_iosf_port_grant_count(device_t dev) { u8 update_val; - u32 rpcd = (pci_read_config32(dev, 0xfc) > 14) & 0x3; + u32 rpcd = (pci_read_config32(dev, 0xfc) >> 14) & 0x3;
switch (rpcd) { case 1:
-
Patrick Georgi