HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32820
Change subject: src/arch: Use 'include <stdlib.h>' when appropriate ......................................................................
src/arch: Use 'include <stdlib.h>' when appropriate
Change-Id: I79f065703b5249ca9630b06de7142bc52675076e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/mmu.c M src/arch/arm/cpu.c M src/arch/mips/mmu.c M src/arch/x86/acpigen_dsm.c M src/arch/x86/cbmem.c M src/arch/x86/mmap_boot.c 6 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/32820/1
diff --git a/src/arch/arm/armv7/mmu.c b/src/arch/arm/armv7/mmu.c index ce9d3fd..f0a5fa6 100644 --- a/src/arch/arm/armv7/mmu.c +++ b/src/arch/arm/armv7/mmu.c @@ -29,12 +29,9 @@ */
#include <assert.h> -#include <stdlib.h> #include <stdint.h> #include <symbols.h> - #include <console/console.h> - #include <arch/cache.h>
#if CONFIG(ARM_LPAE) diff --git a/src/arch/arm/cpu.c b/src/arch/arm/cpu.c index fae1a37..0637bf6 100644 --- a/src/arch/arm/cpu.c +++ b/src/arch/arm/cpu.c @@ -27,7 +27,6 @@ * SUCH DAMAGE. * */ -#include <stdlib.h> #include <arch/cpu.h>
/* Return the CPU struct which is at the high memory address of the stack. diff --git a/src/arch/mips/mmu.c b/src/arch/mips/mmu.c index b144fd3..2ceb2a7 100644 --- a/src/arch/mips/mmu.c +++ b/src/arch/mips/mmu.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <stddef.h> #include <stdint.h> -#include <stdlib.h>
#define MIN_PAGE_SIZE (4 * KiB)
diff --git a/src/arch/x86/acpigen_dsm.c b/src/arch/x86/acpigen_dsm.c index 1aab90b..8c9cd350 100644 --- a/src/arch/x86/acpigen_dsm.c +++ b/src/arch/x86/acpigen_dsm.c @@ -15,7 +15,6 @@
#include <arch/acpigen.h> #include <arch/acpigen_dsm.h> -#include <stdlib.h>
/* ------------------- I2C HID DSM ---------------------------- */
diff --git a/src/arch/x86/cbmem.c b/src/arch/x86/cbmem.c index 648633f..abd163d 100644 --- a/src/arch/x86/cbmem.c +++ b/src/arch/x86/cbmem.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <cbmem.h> #include <arch/acpi.h>
diff --git a/src/arch/x86/mmap_boot.c b/src/arch/x86/mmap_boot.c index abfa024..98b5643 100644 --- a/src/arch/x86/mmap_boot.c +++ b/src/arch/x86/mmap_boot.c @@ -15,7 +15,6 @@
#include <boot_device.h> #include <endian.h> -#include <stdlib.h>
/* The ROM is memory mapped just below 4GiB. Form a pointer for the base. */ #define rom_base ((void *)(uintptr_t)(0x100000000ULL-CONFIG_ROM_SIZE))
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32820
to look at the new patch set (#3).
Change subject: src/arch: Use 'include <stdlib.h>' when appropriate ......................................................................
src/arch: Use 'include <stdlib.h>' when appropriate
Also, including <types.h>, is supposed to provide stdint and stddef.
Change-Id: I79f065703b5249ca9630b06de7142bc52675076e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/mmu.c M src/arch/arm/cpu.c M src/arch/mips/mmu.c M src/arch/x86/acpigen_dsm.c M src/arch/x86/cbmem.c M src/arch/x86/mmap_boot.c 6 files changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/32820/3
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32820 )
Change subject: src/arch: Use 'include <stdlib.h>' when appropriate ......................................................................
Abandoned
see 32023
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/32820 )
Change subject: src/arch: Use 'include <stdlib.h>' when appropriate ......................................................................
Restored
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32820
to look at the new patch set (#4).
Change subject: src/arch: Remove unused <stdlib.h> ......................................................................
src/arch: Remove unused <stdlib.h>
Change-Id: I79f065703b5249ca9630b06de7142bc52675076e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/mmu.c M src/arch/arm/cpu.c M src/arch/arm64/armv8/mmu.c M src/arch/arm64/fit_payload.c M src/arch/riscv/fit_payload.c M src/arch/x86/acpigen_dsm.c M src/arch/x86/cbmem.c M src/arch/x86/include/arch/acpigen.h M src/arch/x86/mmap_boot.c M src/arch/x86/smbios.c 10 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/32820/4
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32820 )
Change subject: src/arch: Remove unused <stdlib.h> ......................................................................
Patch Set 8: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/32820 )
Change subject: src/arch: Remove unused <stdlib.h> ......................................................................
src/arch: Remove unused <stdlib.h>
Change-Id: I79f065703b5249ca9630b06de7142bc52675076e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32820 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/arm/armv7/mmu.c M src/arch/arm/cpu.c M src/arch/arm64/armv8/mmu.c M src/arch/arm64/fit_payload.c M src/arch/riscv/fit_payload.c M src/arch/x86/acpigen_dsm.c M src/arch/x86/cbmem.c M src/arch/x86/include/arch/acpigen.h M src/arch/x86/mmap_boot.c M src/arch/x86/smbios.c 10 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/arch/arm/armv7/mmu.c b/src/arch/arm/armv7/mmu.c index e9d10e2..77b9b4b 100644 --- a/src/arch/arm/armv7/mmu.c +++ b/src/arch/arm/armv7/mmu.c @@ -30,7 +30,6 @@
#include <assert.h> #include <commonlib/helpers.h> -#include <stdlib.h> #include <stdint.h> #include <symbols.h>
diff --git a/src/arch/arm/cpu.c b/src/arch/arm/cpu.c index 87fc6b1..1e0e0fd 100644 --- a/src/arch/arm/cpu.c +++ b/src/arch/arm/cpu.c @@ -27,7 +27,6 @@ * SUCH DAMAGE. * */ -#include <stdlib.h> #include <arch/cpu.h> #include <commonlib/helpers.h>
diff --git a/src/arch/arm64/armv8/mmu.c b/src/arch/arm64/armv8/mmu.c index 67dca48..bdec55c 100644 --- a/src/arch/arm64/armv8/mmu.c +++ b/src/arch/arm64/armv8/mmu.c @@ -28,7 +28,6 @@ */
#include <assert.h> -#include <stdlib.h> #include <stdint.h> #include <string.h> #include <symbols.h> diff --git a/src/arch/arm64/fit_payload.c b/src/arch/arm64/fit_payload.c index 4ade1c7..002df44 100644 --- a/src/arch/arm64/fit_payload.c +++ b/src/arch/arm64/fit_payload.c @@ -14,7 +14,6 @@
#include <console/console.h> #include <bootmem.h> -#include <stdlib.h> #include <program_loading.h> #include <string.h> #include <commonlib/compression.h> diff --git a/src/arch/riscv/fit_payload.c b/src/arch/riscv/fit_payload.c index 78e95fd..89263d3 100644 --- a/src/arch/riscv/fit_payload.c +++ b/src/arch/riscv/fit_payload.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <bootmem.h> -#include <stdlib.h> #include <program_loading.h> #include <commonlib/compression.h> #include <commonlib/cbfs_serialized.h> diff --git a/src/arch/x86/acpigen_dsm.c b/src/arch/x86/acpigen_dsm.c index 64cdd72..294c6c3 100644 --- a/src/arch/x86/acpigen_dsm.c +++ b/src/arch/x86/acpigen_dsm.c @@ -13,7 +13,6 @@
#include <arch/acpigen.h> #include <arch/acpigen_dsm.h> -#include <stdlib.h>
/* ------------------- I2C HID DSM ---------------------------- */
diff --git a/src/arch/x86/cbmem.c b/src/arch/x86/cbmem.c index fc85bc6..b20eb67 100644 --- a/src/arch/x86/cbmem.c +++ b/src/arch/x86/cbmem.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <cbmem.h>
#if CONFIG(CBMEM_TOP_BACKUP) diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h index 8b8c873..11fe232 100644 --- a/src/arch/x86/include/arch/acpigen.h +++ b/src/arch/x86/include/arch/acpigen.h @@ -14,7 +14,6 @@ #ifndef LIBACPI_H #define LIBACPI_H
-#include <stdlib.h> #include <stdint.h> #include <arch/acpi.h> #include <arch/acpi_device.h> diff --git a/src/arch/x86/mmap_boot.c b/src/arch/x86/mmap_boot.c index 7621930..74764fc 100644 --- a/src/arch/x86/mmap_boot.c +++ b/src/arch/x86/mmap_boot.c @@ -13,7 +13,6 @@
#include <boot_device.h> #include <endian.h> -#include <stdlib.h>
/* The ROM is memory mapped just below 4GiB. Form a pointer for the base. */ #define rom_base ((void *)(uintptr_t)(0x100000000ULL-CONFIG_ROM_SIZE)) diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index a599add..8cd4518 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -12,7 +12,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <string.h> #include <smbios.h> #include <console/console.h>
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)