Attention is currently required from: Nico Huber, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Meera Ravindranath, Michael Niewöhner, Usha P, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50955 )
Change subject: soc/intel/common/basecode: Add bootblock common code
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/basecode/Kconfig:
https://review.coreboot.org/c/coreboot/+/50955/comment/3ffff3f9_b81106a1
PS2, Line 6: if SOC_INTEL_COMMON_BASECODE
Not sure why. […]
I have trouble to understand these subdirectories in general. But having
dependencies just to repeat a `select BASE` everywhere seems wrong.
These soc/intel/common subdirectories go much too deep, IMHO. There is
too much hierarchy. With lots of potential discussions about what is
supposed to go where (e.g. is this really about a hardware block or is
this base code? why is report_cpu_info() not in the cpu block?). Removing
the basecode-vs-block distinction would make that obsolete.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d547347ba595edcc3b6253448c8f5060b4fdfff
Gerrit-Change-Number: 50955
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 07 Mar 2021 17:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment