Nico Huber has posted comments on this change. ( https://review.coreboot.org/23478 )
Change subject: inteltool: Fix displaying 64bit spi registers
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/23478/1/util/inteltool/spi.c
File util/inteltool/spi.c:
https://review.coreboot.org/#/c/23478/1/util/inteltool/spi.c@283
PS1, Line 283: *(uint32_t *)(rcba + spibaroffset + spi_register[i].addr + 4), spi_register[i].name);
Mind fixing endianess too?
--
To view, visit
https://review.coreboot.org/23478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bb91517770359599fe5f579c4686434da8d1c27
Gerrit-Change-Number: 23478
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 28 Jan 2018 20:59:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes