Attention is currently required from: Angel Pons, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81906?usp=email )
Change subject: soc/intel/alderlake: Hook up PCIe Power Management to option API
......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81906/comment/f7eb1ddf_6c65946f?usp... :
PS8, Line 7: PCI
nit: PCIe
Done
https://review.coreboot.org/c/coreboot/+/81906/comment/d1b9c72a_c0d753c9?usp... :
PS8, Line 9: PCICLK_PM
Can't find this symbol
Done
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/81906/comment/bff174c6_658aa077?usp... :
PS8, Line 496: pciexp_aspm
It seems redundant execution of `get_uint_option()`. […]
Done
https://review.coreboot.org/c/coreboot/+/81906/comment/97a3072c_a2468cc2?usp... :
PS8, Line 535: bool pciexp_clk_pm = get_uint_option("pciexp_clk_pm", CONFIG(PCIEXP_CLK_PM));
: bool pciexp_aspm = get_uint_option("pciexp_aspm", CONFIG(PCIEXP_ASPM));
: bool pciexp_l1_sub_state = get_uint_option("pciexp_l1_sub_state",
: CONFIG(PCIEXP_L1_SUB_STATE));
Sure
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b06a7c734a4fd4073e86c668742ee35e1d79956
Gerrit-Change-Number: 81906
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 02 Oct 2024 14:22:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com