Attention is currently required from: CoolStar, Matt DeVillier, Nick Vaccaro.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77577?usp=email )
Change subject: mb/google/brya: Enable GNA scoring accelerator
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/77577/comment/e9bfd131_004141c4 :
PS3, Line 161: on
I'm thinking it might be useful to add a new keyword 'by_config <CONFIG_OPTION' That would allow us to enable/disable blocks based on a config option. If the config option is 'y', the device is enabled, otherwise it's disabled.
Then we could enable this for non-chromeos builds.
if you think that'd be useful, let me know and I'll code it up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77577?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib97278820d93a8fae52a74f36a5f60d9a9b2b363
Gerrit-Change-Number: 77577
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Comment-Date: Sun, 03 Sep 2023 04:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment