Attention is currently required from: Paul Menzel.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76219?usp=email )
Change subject: mb/google/corsola: Add support for AW37503 Power IC ......................................................................
Patch Set 2:
(4 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/76219/comment/68d864dc_6f4f53ca : PS1, Line 11: program the registers to control the positive/negative output supply.
'ouput' may be misspelled - perhaps 'output'? […]
Done
https://review.coreboot.org/c/coreboot/+/76219/comment/c9338878_d031122e : PS1, Line 15: In the starmie, we need +-6V supply for the MIPI panel. So we setting
'programing' may be misspelled - perhaps 'programming'? […]
Done
https://review.coreboot.org/c/coreboot/+/76219/comment/3bbe5aff_cc846bf3 : PS1, Line 15: we setting
Imperative mood: set
Done
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/76219/comment/66af24de_c089a638 : PS1, Line 59: /* Initialize I2C bus for PMIC */
The comment seems redundant, as the code line below basically reads the same.
Done