Attention is currently required from: Alicja Michalska.
Angel Pons has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email )
Change subject: Documentation: Add Erying Polestar G613 Pro ......................................................................
Patch Set 5:
(7 comments)
File Documentation/mainboard/erying/tgl_matx.md:
PS5: I guess naming the file `tgl_μatx.md` is just asking for trouble 😄
https://review.coreboot.org/c/coreboot/+/81611/comment/56ce3ed2_2aa62f44?usp... : PS5, Line 15: | Microcode | CPU Microcode | Required (see notes) | Technically, those are microcode *updates*. But I'm being pedantic.
https://review.coreboot.org/c/coreboot/+/81611/comment/d8d1f275_7722949a?usp... : PS5, Line 21: | FD | Intel Flash Descriptor | Optional (if SI_BIOS)| IFD is always needed, unless flashing the BIOS region only
https://review.coreboot.org/c/coreboot/+/81611/comment/483ced0c_b8fe4678?usp... : PS5, Line 28: overal typo: overall
```suggestion (Advanced Programmable Interrupt Controller), resulting in overall instability. ```
https://review.coreboot.org/c/coreboot/+/81611/comment/5454f8e3_3f6e5c3b?usp... : PS5, Line 89: x3 PCIe x3 might be a cute face, but I think it's a typo 😄
https://review.coreboot.org/c/coreboot/+/81611/comment/0de7a51a_d18b6298?usp... : PS5, Line 119: bifurfication Typo (bifurcation), trailing space and PCIe spelling:
```suggestion - PCIe lane bifurcation ```
File Documentation/mainboard/erying/tgl_matx_board.jpg:
PS5: See if you can use something to optimise the image size. I think the size could be reduced by at least 50% without losing much quality.