Attention is currently required from: Ivy Jian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79295?usp=email )
Change subject: mb/google/brox: Update storage settings for SSD and UFS
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79295/comment/36abb0d8_4b60eeb5 :
PS3, Line 16: unexpect
Done.
A revision/version would be nice to have.
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/79295/comment/a5f55737_c9048302 :
PS3, Line 50: select DRIVERS_INTEL_ISH
This is required for enabling UFS.
Yes, so it could be ordered before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79295?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88922bcfa13652006aa10078c3c444624fd4575e
Gerrit-Change-Number: 79295
Gerrit-PatchSet: 4
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yen-hsing Lee
yen-hsing.lee@quanta.corp-partner.google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 30 Nov 2023 09:06:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-MessageType: comment